Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 190443002: [DevTools] Add canProfilePower command and plumb power handlers to RenderViewDevToolsAgentHost (Closed)

Created:
6 years, 9 months ago by Pan
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Add canProfilePower command and plumb power handlers to RenderViewDevToolsAgentHost BUG=337138 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M content/browser/devtools/devtools_power_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_power_handler.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Pan
Hi @pfeldman, This CL is ready to review, thanks for your help. Pan
6 years, 9 months ago (2014-03-07 09:08:28 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-07 13:29:11 UTC) #2
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-07 14:10:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/190443002/1
6 years, 9 months ago (2014-03-07 14:11:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 14:46:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 14:46:17 UTC) #6
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-09 02:37:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/190443002/1
6 years, 9 months ago (2014-03-09 02:37:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 04:08:36 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278297
6 years, 9 months ago (2014-03-09 04:08:36 UTC) #10
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-09 05:22:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/190443002/1
6 years, 9 months ago (2014-03-09 05:22:53 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 10:59:07 UTC) #13
Message was sent while issue was closed.
Change committed as 255845

Powered by Google App Engine
This is Rietveld 408576698