third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-declaration-parent-rule-expected.txt - Issue 1904423002: Remove Oilpan-only StyleSheet/ test failures from TestExpectations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-declaration-parent-rule-expected.txt

Issue 1904423002: Remove Oilpan-only StyleSheet/ test failures from TestExpectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-stylesheet-without-wrapper-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Test that CSS rules don't lose custom properties on GC when only reachable throu gh its declarations.	1 Test that CSS rules don't lose custom properties on GC when only reachable throu gh its declarations.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 FAIL style.parentRule.foo should be bar. Threw exception TypeError: Cannot read property 'foo' of null	6 FAIL style.parentRule.foo should be bar (of type string). Was undefined (of type undefined).
	sof 2016/04/22 12:30:57 Is this (and the other gc-* tests) expected to fai Is this (and the other gc-* tests) expected to fail still? keishi 2016/04/26 05:05:36 I was able to make gc-declaration-parent-rule.html Show quoted text On 2016/04/22 12:30:57, sof wrote: > Is this (and the other gc-* tests) expected to fail still? I was able to make gc-declaration-parent-rule.html pass by adding SetWrapperReferenceTo to CSSStyleDeclaration. I tried to do the same for gc-declaration-parent-stylesheet.html but it didn't work. The wrapper for parentRule/parentStyleSheet is being disposed during the GC. I'm not sure why SetWrapperReferenceTo worked. Can +yukishiino or +haraken teach me how the wrapper lifetime should be managed?
7 PASS successfullyParsed is true	7 PASS successfullyParsed is true

8	8

9 TEST COMPLETE	9 TEST COMPLETE

10	10

OLD	NEW