Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1904403004: Remove PlatformImpl::createURLLoader (Closed)

Created:
4 years, 8 months ago by yhirano
Modified:
4 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PlatformImpl::createURLLoader PlatformImpl::createURLLoader is used only by tests. In that case, resource_dispatcher is null and the returned url loader should be used only for local resources such as data URLs. This CL moves the implementation to TestBlinkWebUnitTestSupport to make it explicit. BUG=603396 Committed: https://crrev.com/6e4dac6c4668c879b0034d8ab4ed82a96c7a51be Cr-Commit-Position: refs/heads/master@{#389421}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M content/child/blink_platform_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 2 3 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yhirano
4 years, 8 months ago (2016-04-25 06:50:33 UTC) #8
kinuko
\o/ yes, lgtm
4 years, 8 months ago (2016-04-25 06:56:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904403004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904403004/60001
4 years, 8 months ago (2016-04-25 07:04:27 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-25 07:08:05 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 07:10:03 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6e4dac6c4668c879b0034d8ab4ed82a96c7a51be
Cr-Commit-Position: refs/heads/master@{#389421}

Powered by Google App Engine
This is Rietveld 408576698