Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 19044004: Fix "No such file or directory" error in sysroot_ld_path.sh if ld.so.conf include pattern doesn't m… (Closed)

Created:
7 years, 5 months ago by ostap
Modified:
7 years, 4 months ago
Reviewers:
Lei Zhang, Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix "No such file or directory" error in sysroot_ld_path.sh if ld.so.conf include pattern doesn't match any file. Sometimes ld.so.conf has pattern include like "include ld.so.conf.d/*.conf", but there is no files that match pattern. In this case "for" loop in process_ld_so_conf function fails with error "No such file or directory". This patch uses "ls" to check that pattern matches at least one file. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/linux/sysroot_ld_path.sh View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ostap
7 years, 5 months ago (2013-07-11 07:21:04 UTC) #1
Sam Clegg
Seems good to me, but +thestig who wrote this script originally and might have more ...
7 years, 5 months ago (2013-07-11 15:41:07 UTC) #2
Lei Zhang
lgtm
7 years, 5 months ago (2013-07-16 02:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/19044004/1
7 years, 5 months ago (2013-07-17 17:25:15 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=15734
7 years, 5 months ago (2013-07-17 19:54:01 UTC) #5
Lei Zhang
On 2013/07/17 19:54:01, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-07-17 19:56:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/19044004/1
7 years, 4 months ago (2013-07-27 20:45:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/19044004/1
7 years, 4 months ago (2013-07-27 20:56:33 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=180631
7 years, 4 months ago (2013-07-28 01:44:24 UTC) #9
ostap
On 2013/07/28 01:44:24, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 4 months ago (2013-07-29 14:03:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/19044004/1
7 years, 4 months ago (2013-07-29 14:03:59 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-07-29 21:51:29 UTC) #12
Message was sent while issue was closed.
Change committed as 214230

Powered by Google App Engine
This is Rietveld 408576698