Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1904383002: Tweak "Typical sources and deps modifications" section. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, Sam McNally
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak "Typical sources and deps modifications" section. The current example, while a literal translation of the gyp version, is misleading people: https://codereview.chromium.org/1906283002/#msg7 BUG=none Committed: https://crrev.com/fae1035167c4f29a410485d8bdaa928046c4aa22 Cr-Commit-Position: refs/heads/master@{#389077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tools/gn/docs/cookbook.md View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
4 years, 8 months ago (2016-04-22 02:05:37 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-22 02:21:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904383002/1
4 years, 8 months ago (2016-04-22 11:00:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:24:38 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-22 18:02:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fae1035167c4f29a410485d8bdaa928046c4aa22
Cr-Commit-Position: refs/heads/master@{#389077}

Powered by Google App Engine
This is Rietveld 408576698