Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1904333002: cc: Remove unnecessary state from scheduler state machine. (Closed)

Created:
4 years, 8 months ago by sunnyps
Modified:
4 years, 8 months ago
Reviewers:
enne (OOO)
CC:
boliu_chomium.org, chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove unnecessary state from scheduler state machine. BEGIN_IMPL_FRAME_STATE_BEGIN_FRAME_STARTING was used for animation and webview invalidate. This is unnecessary now given that animation has been moved to LTHI::WillBeginImplFrame. BUG=602485 R=enne@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/02d0cfecc62ac64f61863f647234c562398e1d5c Cr-Commit-Position: refs/heads/master@{#389195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -52 lines) Patch
M cc/scheduler/scheduler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 15 chunks +1 line, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sunnyps
PTAL This was split out of https://codereview.chromium.org/1887243002/ +boliu@ FYI - the invalidate action used to ...
4 years, 8 months ago (2016-04-21 23:21:12 UTC) #2
enne (OOO)
This is great cleanup, thanks. lgtm
4 years, 8 months ago (2016-04-22 17:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904333002/1
4 years, 8 months ago (2016-04-22 18:27:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 19:04:53 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02d0cfecc62ac64f61863f647234c562398e1d5c
Cr-Commit-Position: refs/heads/master@{#389195}

Powered by Google App Engine
This is Rietveld 408576698