Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1904323002: kiosk: Install secondary app after DelayNetworkCall (Closed)

Created:
4 years, 8 months ago by xiyuan
Modified:
4 years, 8 months ago
Reviewers:
jennyz
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Install secondary app after DelayNetworkCall Secondary apps install happens after network is configured. Wrap the actual install call with DelayNetworkCall to avoid failure caused by flaky network status. BUG=600878 Committed: https://crrev.com/35fa7b8dd3254770833edf5326ef24410b3613b1 Cr-Commit-Position: refs/heads/master@{#389558}

Patch Set 1 #

Patch Set 2 : fix offline launch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
xiyuan
4 years, 8 months ago (2016-04-21 23:12:34 UTC) #2
jennyz
lgtm
4 years, 8 months ago (2016-04-21 23:42:08 UTC) #3
xiyuan
Revised CL to move DelayNetworkCall after we have determined that secondary app install is needed. ...
4 years, 8 months ago (2016-04-25 19:23:20 UTC) #4
jennyz
lgtm
4 years, 8 months ago (2016-04-25 20:31:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904323002/20001
4 years, 8 months ago (2016-04-25 20:38:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 20:44:42 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:46:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35fa7b8dd3254770833edf5326ef24410b3613b1
Cr-Commit-Position: refs/heads/master@{#389558}

Powered by Google App Engine
This is Rietveld 408576698