Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904303002: Remove next batch of CFX_ arrays from fpdf_edit_doc.cpp (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove next batch of CFX_ arrays from fpdf_edit_doc.cpp Committed: https://pdfium.googlesource.com/pdfium/+/b88b8dc91ff8987f327c2c5180cacdad1d4464d4

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : std::set seems more appropriate #

Patch Set 4 : Use ScopedSetInsertion to be totally cool. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 2 3 5 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tom Sepez
Lei, next review.
4 years, 8 months ago (2016-04-21 23:20:42 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-21 23:22:35 UTC) #3
Tom Sepez
On 2016/04/21 23:22:35, Lei Zhang wrote: > lgtm And I changed it.
4 years, 8 months ago (2016-04-21 23:24:51 UTC) #4
Lei Zhang
Sure, still lgtm.
4 years, 8 months ago (2016-04-21 23:27:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904303002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904303002/60001
4 years, 8 months ago (2016-04-22 00:29:33 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 00:41:09 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/b88b8dc91ff8987f327c2c5180cacdad1d44...

Powered by Google App Engine
This is Rietveld 408576698