Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks

net/proxy/dhcpcsvc_init_win.cc

Index: net/proxy/dhcpcsvc_init_win.cc
diff --git a/net/proxy/dhcpcsvc_init_win.cc b/net/proxy/dhcpcsvc_init_win.cc
index 7e32aeae9cd5593b3d788341cdd5bc9f8d845ece..4e5a89156c33c2732014d3f4fcf036881dc0c785 100644
--- a/net/proxy/dhcpcsvc_init_win.cc
+++ b/net/proxy/dhcpcsvc_init_win.cc
@@ -20,14 +20,14 @@ class DhcpcsvcInitSingleton {
     DCHECK(err == ERROR_SUCCESS);  // DCHECK_EQ complains of unsigned mismatch.
   }
 
-  ~DhcpcsvcInitSingleton() {
-    // Worker pool threads that use the DHCP API may still be running, so skip
-    // cleanup.
-  }
+ private:
+  ~DhcpcsvcInitSingleton() {}

[gab, 2016/04/26 20:11:47]

Actually never mind the private destructor, I'd misunderstood the bug as
highlighted in my other comment (I thought somehow running the destructor was
the issue and thus that we should make sure it doesn't run).

The issue is with the instance going away and thus it makes more sense to
document this via the Leaky instance and forgo the private destructor (which is
an unnecessary burden that could one day prevent proper unit-testing).

 };
 
-static base::LazyInstance<DhcpcsvcInitSingleton> g_dhcpcsvc_init_singleton =
-    LAZY_INSTANCE_INITIALIZER;
+// Worker pool threads that use the DHCP API may still be running at shutdown.
+// Leak instance and skip cleanup.
+static base::LazyInstance<DhcpcsvcInitSingleton>::Leaky
+    g_dhcpcsvc_init_singleton = LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace