Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904253002: Convert //media/blink from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //media/blink from scoped_ptr to std::unique_ptr BUG=554298 R=jrummell@chromium.org Committed: https://crrev.com/3076abbf53ffb74830a097f1c4f7dd232f246fad Cr-Commit-Position: refs/heads/master@{#389230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -157 lines) Patch
M media/blink/active_loader.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/blink/active_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/buffered_data_source.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/buffered_data_source.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/blink/buffered_data_source_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/blink/buffered_resource_loader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/buffered_resource_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/buffered_resource_loader_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/cdm_session_adapter.h View 3 chunks +13 lines, -12 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 3 chunks +17 lines, -13 lines 0 comments Download
M media/blink/key_system_config_selector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/blink/key_system_config_selector.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/key_system_config_selector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/multibuffer.h View 5 chunks +5 lines, -5 lines 0 comments Download
M media/blink/multibuffer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/blink/multibuffer_data_source.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M media/blink/multibuffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/blink/run_all_unittests.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/blink/texttrack_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M media/blink/texttrack_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/url_index.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/url_index.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/video_frame_compositor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 8 chunks +9 lines, -9 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/websourcebuffer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
4 years, 8 months ago (2016-04-21 22:38:34 UTC) #1
jrummell
lgtm
4 years, 8 months ago (2016-04-22 20:13:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904253002/1
4 years, 8 months ago (2016-04-22 20:34:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 20:42:51 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 20:44:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3076abbf53ffb74830a097f1c4f7dd232f246fad
Cr-Commit-Position: refs/heads/master@{#389230}

Powered by Google App Engine
This is Rietveld 408576698