Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190423002: Correctly handle has_more in PepperInternalFileRefBackend (Closed)

Created:
6 years, 9 months ago by hashimoto
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Correctly handle has_more in PepperInternalFileRefBackend BUG=347900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hashimoto
6 years, 9 months ago (2014-03-07 08:49:10 UTC) #1
dmichael (off chromium)
lgtm
6 years, 9 months ago (2014-03-07 17:02:10 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-08 04:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190423002/1
6 years, 9 months ago (2014-03-08 11:19:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:22:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234359
6 years, 9 months ago (2014-03-08 14:22:19 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-08 14:45:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190423002/1
6 years, 9 months ago (2014-03-08 14:46:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 15:21:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234415
6 years, 9 months ago (2014-03-08 15:21:22 UTC) #10
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-09 01:58:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190423002/1
6 years, 9 months ago (2014-03-09 01:59:07 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 02:51:15 UTC) #13
Message was sent while issue was closed. 
Change committed as 255811

Powered by Google App Engine
This is Rietveld 408576698