Convert //media/filters from scoped_ptr to std::unique_ptr

Convert //media/filters from scoped_ptr to std::unique_ptr

BUG=554298
R=ddorwin@chromium.org

Committed: https://crrev.com/254c536ce14380dc8009240cfff27117a1d52897
Cr-Commit-Position: refs/heads/master@{#388991}

[ddorwin, 2016-04-21 22:54:55]

I stopped after my last comment. What pattern are you using for including
<memory>?

https://codereview.chromium.org/1904213003/diff/1/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/chunk_demuxer...
media/filters/chunk_demuxer.h:12: #include <map>
Why isn't <memory> included in this file?

https://codereview.chromium.org/1904213003/diff/1/media/filters/chunk_demuxer...
File media/filters/chunk_demuxer_unittest.cc (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/chunk_demuxer...
media/filters/chunk_demuxer_unittest.cc:9: #include <algorithm>
Why isn't <memory> included in this file like the other unit tests?

https://codereview.chromium.org/1904213003/diff/1/media/filters/decoder_stream.h
File media/filters/decoder_stream.h (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/decoder_strea...
media/filters/decoder_stream.h:9: 
<memory>?

https://codereview.chromium.org/1904213003/diff/1/media/filters/decrypting_au...
File media/filters/decrypting_audio_decoder_unittest.cc (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/decrypting_au...
media/filters/decrypting_audio_decoder_unittest.cc:7: #include <string>
ditto here and the next three test files.

https://codereview.chromium.org/1904213003/diff/1/media/filters/ffmpeg_demuxe...
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/ffmpeg_demuxe...
media/filters/ffmpeg_demuxer.cc:8: #include <memory>
This is the first non-test .cc file to have this added. Why?

[dcheng, 2016-04-21 22:56:23]

On 2016/04/21 at 22:54:55, ddorwin wrote:
> I stopped after my last comment. What pattern are you using for including
<memory>?

If a file used to #include "base/memory/scoped_ptr.h", it now includes <memory>.
That's the only rule.

Fixing IWYU problems is a non-goal: it's currently hard to automate these fixes
and there's no enforcement anyway. So if it still builds, that's good enough.

[ddorwin, 2016-04-21 23:14:20]

LGTM. There's one file that I think you should just delete scoped_ptr.h (even if
this is mostly automated).

https://codereview.chromium.org/1904213003/diff/1/media/filters/h265_parser.cc
File media/filters/h265_parser.cc (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/h265_parser.c...
media/filters/h265_parser.cc:9: #include <memory>
It looks like this isn't even necessary.

[dcheng, 2016-04-21 23:16:27]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-21 23:16:28]

https://codereview.chromium.org/1904213003/diff/1/media/filters/h265_parser.cc
File media/filters/h265_parser.cc (right):

https://codereview.chromium.org/1904213003/diff/1/media/filters/h265_parser.c...
media/filters/h265_parser.cc:9: #include <memory>
On 2016/04/21 at 23:14:20, ddorwin wrote:
> It looks like this isn't even necessary.

Done.

[dcheng, 2016-04-21 23:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/1904213003/#ps20001
(title: "remove include")

[commit-bot: I haz the power, 2016-04-21 23:16:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904213003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904213003/20001

[commit-bot: I haz the power, 2016-04-22 01:12:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:43:05]

Description was changed from

==========
Convert //media/filters from scoped_ptr to std::unique_ptr

BUG=554298
R=ddorwin@chromium.org
==========

to

==========
Convert //media/filters from scoped_ptr to std::unique_ptr

BUG=554298
R=ddorwin@chromium.org

Committed: https://crrev.com/254c536ce14380dc8009240cfff27117a1d52897
Cr-Commit-Position: refs/heads/master@{#388991}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:06]

Patchset 2 (id:??) landed as
https://crrev.com/254c536ce14380dc8009240cfff27117a1d52897
Cr-Commit-Position: refs/heads/master@{#388991}