Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 1904213002: QUIC: support diversified keys with version 33. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hkdf
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 4ef43eab092a634fe8fe768b1d5561f39142da29..b70b348a67976f79ef9b57bd6b4a69d1648e4efa 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -629,15 +629,11 @@ TEST_P(QuicDispatcherStatelessRejectTest, ParameterizedBasicTest) {
// Verify the stopgap test: Packets with truncated connection IDs should be
// dropped.
-class QuicDispatcherTestStrayPacketConnectionId
- : public QuicDispatcherTest,
- public ::testing::WithParamInterface<QuicConnectionIdLength> {};
+class QuicDispatcherTestStrayPacketConnectionId : public QuicDispatcherTest {};
// Packets with truncated connection IDs should be dropped.
-TEST_P(QuicDispatcherTestStrayPacketConnectionId,
+TEST_F(QuicDispatcherTestStrayPacketConnectionId,
StrayPacketTruncatedConnectionId) {
- const QuicConnectionIdLength connection_id_length = GetParam();
-
CreateTimeWaitListManager();
IPEndPoint client_address(net::test::Loopback4(), 1);
@@ -650,15 +646,9 @@ TEST_P(QuicDispatcherTestStrayPacketConnectionId,
EXPECT_CALL(*time_wait_list_manager_, AddConnectionIdToTimeWait(_, _, _, _))
.Times(0);
ProcessPacket(client_address, connection_id, true, false, "data",
- connection_id_length, PACKET_6BYTE_PACKET_NUMBER);
+ PACKET_0BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER);
}
-INSTANTIATE_TEST_CASE_P(ConnectionIdLength,
- QuicDispatcherTestStrayPacketConnectionId,
- ::testing::Values(PACKET_0BYTE_CONNECTION_ID,
- PACKET_1BYTE_CONNECTION_ID,
- PACKET_4BYTE_CONNECTION_ID));
-
class BlockingWriter : public QuicPacketWriterWrapper {
public:
BlockingWriter() : write_blocked_(false) {}
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698