Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1904193002: clang/win: Disable precompiled headers. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Disable precompiled headers. The protobuf3 roll triggered a compiler crash in the pch codepath. BUG=605570 R=hans@chromium.org Committed: https://crrev.com/589ef6b6a9d60b21d6c78b92887de1b9d04b7e0f Cr-Commit-Position: refs/heads/master@{#388887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/config/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/win_precompile.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
4 years, 8 months ago (2016-04-21 20:24:41 UTC) #2
hans
lgtm
4 years, 8 months ago (2016-04-21 20:25:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904193002/1
4 years, 8 months ago (2016-04-21 20:26:34 UTC) #5
Nico
Committed patchset #1 (id:1) manually as 589ef6b6a9d60b21d6c78b92887de1b9d04b7e0f (presubmit successful).
4 years, 8 months ago (2016-04-21 20:42:18 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/589ef6b6a9d60b21d6c78b92887de1b9d04b7e0f Cr-Commit-Position: refs/heads/master@{#388887}
4 years, 8 months ago (2016-04-22 19:39:04 UTC) #9
Nico
4 years, 8 months ago (2016-04-22 19:41:09 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1914673002/ by thakis@chromium.org.

The reason for reverting is: rnk might have fixed this upstream, let's give it a
try :-).

Powered by Google App Engine
This is Rietveld 408576698