Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1904183002: Revert of DocumentLoader should commit the load before creating a DocumentWriter (Closed)

Created:
4 years, 8 months ago by meacer
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DocumentLoader should commit the load before creating a DocumentWriter (patchset #10 id:180001 of https://codereview.chromium.org/1859763003/ ) Reason for revert: Bad CL description Original issue's description: > The current order of events in DocumentLoader causes an HTML parser to be created via DocumentWriter::create before the load commits. This causes the HTML parser to read a stale value for scriptEnabled setting in HTMLParserOptions if the setting changes between page loads. This in turn breaks the rendering of noscript tags. > > This CL moves receivedFirstData call before DocumentWriter::create and FrameLoader::didBeginDocument so that the load is committed before the HTML parser is created and the correct scriptEnabled value is used by the parser. It also moves creation of Content Security Policy and setting saved form data to a new callback didInstallNewDocument. > > NOTE: This also changes the order of callbacks in WebFrameClient. > The OLD order when loading a document was: > 1. didStartProvisionalLoad > 2. didCreateNewDocument > 3. didCommitProvisionalLoad > 4. didCreateDocumentElement > > The NEW order is: > 1. didStartProvisionalLoad > 2. didCommitProvisionalLoad > 3. didCreateNewDocument > 4. didCreateDocumentElement > > BUG=232410 TBR=dcheng@chromium.org,bauerb@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=232410 Committed: https://crrev.com/19b48b337c508b5854aad0a605b54e044f0e2dd1 Cr-Commit-Position: refs/heads/master@{#388863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -177 lines) Patch
M chrome/renderer/content_settings_observer_browsertest.cc View 7 chunks +33 lines, -142 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 3 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
meacer
Created Revert of DocumentLoader should commit the load before creating a DocumentWriter
4 years, 8 months ago (2016-04-21 19:51:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904183002/1
4 years, 8 months ago (2016-04-21 19:51:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 19:52:56 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:38:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19b48b337c508b5854aad0a605b54e044f0e2dd1
Cr-Commit-Position: refs/heads/master@{#388863}

Powered by Google App Engine
This is Rietveld 408576698