DescriptionRevert of DocumentLoader should commit the load before creating a DocumentWriter (patchset #10 id:180001 of https://codereview.chromium.org/1859763003/ )
Reason for revert:
Bad CL description
Original issue's description:
> The current order of events in DocumentLoader causes an HTML parser to be created via DocumentWriter::create before the load commits. This causes the HTML parser to read a stale value for scriptEnabled setting in HTMLParserOptions if the setting changes between page loads. This in turn breaks the rendering of noscript tags.
>
> This CL moves receivedFirstData call before DocumentWriter::create and FrameLoader::didBeginDocument so that the load is committed before the HTML parser is created and the correct scriptEnabled value is used by the parser. It also moves creation of Content Security Policy and setting saved form data to a new callback didInstallNewDocument.
>
> NOTE: This also changes the order of callbacks in WebFrameClient.
> The OLD order when loading a document was:
> 1. didStartProvisionalLoad
> 2. didCreateNewDocument
> 3. didCommitProvisionalLoad
> 4. didCreateDocumentElement
>
> The NEW order is:
> 1. didStartProvisionalLoad
> 2. didCommitProvisionalLoad
> 3. didCreateNewDocument
> 4. didCreateDocumentElement
>
> BUG=232410
TBR=dcheng@chromium.org,bauerb@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=232410
Committed: https://crrev.com/19b48b337c508b5854aad0a605b54e044f0e2dd1
Cr-Commit-Position: refs/heads/master@{#388863}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|