Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1904163003: Add new constructor to HKDF that allows the client and server key/IV (Closed)

Created:
4 years, 8 months ago by Ryan Hamilton
Modified:
4 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new constructor to HKDF that allows the client and server key/IV lengths to be different. Committed: https://crrev.com/0db8686bdf6275fc54581bd7ffbbf796faa8f646 Cr-Commit-Position: refs/heads/master@{#388912}

Patch Set 1 #

Patch Set 2 : StringPiece #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -15 lines) Patch
M crypto/hkdf.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M crypto/hkdf.cc View 1 3 chunks +40 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
As discussed, here's the HKDF CL. But I look forward to the elimination of HKDF ...
4 years, 8 months ago (2016-04-21 20:08:43 UTC) #2
davidben
lgtm
4 years, 8 months ago (2016-04-21 20:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904163003/20001
4 years, 8 months ago (2016-04-21 20:13:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/82875)
4 years, 8 months ago (2016-04-21 20:35:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904163003/20001
4 years, 8 months ago (2016-04-21 20:43:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 21:51:54 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0db8686bdf6275fc54581bd7ffbbf796faa8f646
Cr-Commit-Position: refs/heads/master@{#388912}

Powered by Google App Engine
This is Rietveld 408576698