Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904153002: Add a stress testing flag --background-compilation-stop-alot; add an extra check if background comp… (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a stress testing flag --background-compilation-stop-alot; add an extra check if background compilation is being stopped. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fc55cb96a85ba1185b8a7c3966c564a09b8a3105

Patch Set 1 #

Patch Set 2 : restore #

Total comments: 2

Patch Set 3 : r #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 4 chunks +19 lines, -7 lines 0 comments Download
M runtime/vm/flag_list.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 8 months ago (2016-04-21 18:09:04 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1904153002/diff/20001/runtime/vm/flag_list.h File runtime/vm/flag_list.h (right): https://codereview.chromium.org/1904153002/diff/20001/runtime/vm/flag_list.h#newcode37 runtime/vm/flag_list.h:37: "Sttress test system: stop nackground compiler often.") \ ...
4 years, 8 months ago (2016-04-21 19:32:25 UTC) #3
srdjan
https://codereview.chromium.org/1904153002/diff/20001/runtime/vm/flag_list.h File runtime/vm/flag_list.h (right): https://codereview.chromium.org/1904153002/diff/20001/runtime/vm/flag_list.h#newcode37 runtime/vm/flag_list.h:37: "Sttress test system: stop nackground compiler often.") \ On ...
4 years, 8 months ago (2016-04-21 20:24:29 UTC) #4
srdjan
4 years, 8 months ago (2016-04-21 20:33:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fc55cb96a85ba1185b8a7c3966c564a09b8a3105.

Powered by Google App Engine
This is Rietveld 408576698