Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1904143002: Assert that CFX_ strings are pointer-size. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Assert that CFX_ strings are pointer-size. The principle has been implicit in the implementation, but make it obvious for future generations. Committed: https://pdfium.googlesource.com/pdfium/+/334319477703b5ba136373c4e3598e9a56e7f081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M core/fxcrt/fx_basic_bstring.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Dan, quick review.
4 years, 8 months ago (2016-04-21 17:31:47 UTC) #3
dsinclair
lgtm
4 years, 8 months ago (2016-04-21 17:32:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904143002/1
4 years, 8 months ago (2016-04-21 17:32:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 18:17:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/334319477703b5ba136373c4e3598e9a56e7...

Powered by Google App Engine
This is Rietveld 408576698