Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 19041005: Introduce css3TextEnabled instead of CSS3_TEXT. (Closed)

Created:
7 years, 5 months ago by dw.im
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce css3TextEnabled instead of CSS3_TEXT. Introduce css3TextEnabled instead of CSS3_TEXT, and remove '-webkit' prefix from the '-webkit-text-align-last' property. BUG=259332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154081

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Patch for landing #

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -117 lines) Patch
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 1 chunk +51 lines, -51 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last-inherited.js View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 6 chunks +9 lines, -13 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperties.in View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSPropertyNames.in View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 6 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Julien - ping for review
lgtm https://codereview.chromium.org/19041005/diff/1/Source/core/page/UseCounter.cpp File Source/core/page/UseCounter.cpp (right): https://codereview.chromium.org/19041005/diff/1/Source/core/page/UseCounter.cpp#newcode490 Source/core/page/UseCounter.cpp:490: case CSSPropertyTextAlignLast: return 423; That's wrong, you shouldn't ...
7 years, 5 months ago (2013-07-12 00:18:00 UTC) #1
dw.im
https://codereview.chromium.org/19041005/diff/1/Source/core/page/UseCounter.cpp File Source/core/page/UseCounter.cpp (right): https://codereview.chromium.org/19041005/diff/1/Source/core/page/UseCounter.cpp#newcode490 Source/core/page/UseCounter.cpp:490: case CSSPropertyTextAlignLast: return 423; On 2013/07/12 00:18:00, Julien Chaffraix ...
7 years, 5 months ago (2013-07-12 00:21:04 UTC) #2
dw.im
I've deleted a blank line which I made by mistake.
7 years, 5 months ago (2013-07-12 00:23:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/19041005/7001
7 years, 5 months ago (2013-07-12 00:24:20 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-12 00:52:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/19041005/7001
7 years, 5 months ago (2013-07-12 01:08:41 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16354
7 years, 5 months ago (2013-07-12 02:02:58 UTC) #7
dw.im
Add textAlignLast into the css-properties-as-js-properties-expected.txt at the Patch Set #4.
7 years, 5 months ago (2013-07-12 02:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/19041005/19002
7 years, 5 months ago (2013-07-12 02:12:52 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 04:49:31 UTC) #10
Message was sent while issue was closed.
Change committed as 154081

Powered by Google App Engine
This is Rietveld 408576698