[interpreter] Heal closures when bytecode array is gone.

[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/5c8609de9d597000fdb92dffe954d7ed994488b2
Cr-Commit-Position: refs/heads/master@{#35724}

[Michael Starzinger, 2016-04-21 15:09:47]

Starting on ports now, but ready for a first round of comments.

[rmcilroy, 2016-04-21 15:16:02]

Approach looks good, one suggestion.

https://codereview.chromium.org/1904093002/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1904093002/diff/1/src/ia32/builtins-ia32.cc#n...
src/ia32/builtins-ia32.cc:570: __ JumpIfSmi(kInterpreterBytecodeArrayRegister,
&bytecode_array_not_present);
Maybe you could just compare with undefined to check for it not being present,
and keep the debug code assert only if the object is not undefined - I think
that would be slightly more efficient, WDYT?

[Michael Starzinger, 2016-04-21 15:43:09]

Thanks! Addressed comments. Doing ports now.

https://codereview.chromium.org/1904093002/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1904093002/diff/1/src/ia32/builtins-ia32.cc#n...
src/ia32/builtins-ia32.cc:570: __ JumpIfSmi(kInterpreterBytecodeArrayRegister,
&bytecode_array_not_present);
On 2016/04/21 15:16:02, rmcilroy wrote:
> Maybe you could just compare with undefined to check for it not being present,
> and keep the debug code assert only if the object is not undefined - I think
> that would be slightly more efficient, WDYT?

Done. Good point.

[Michael Starzinger, 2016-04-21 15:45:21]

Description was changed from

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching to
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n
==========

[Michael Starzinger, 2016-04-21 16:32:17]

Ports done. PTAL.

[Benedikt Meurer, 2016-04-22 10:29:04]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-04-22 10:29:05]

LGTM from my side.

[rmcilroy, 2016-04-22 10:38:48]

LGTM++

[Michael Starzinger, 2016-04-22 10:50:19]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-04-22 10:50:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904093002/40001

[commit-bot: I haz the power, 2016-04-22 11:13:00]

Description was changed from

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n
==========

[commit-bot: I haz the power, 2016-04-22 11:13:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:15:26]

Description was changed from

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Heal closures when bytecode array is gone.

This ensures the InterpreterEntryTrampoline heals code entry fields
inside closures when being called without a valid bytecode array. This
is preparatory work to allow removal of bytecode when switching some
functions to other types of code.

R=rmcilroy@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/5c8609de9d597000fdb92dffe954d7ed994488b2
Cr-Commit-Position: refs/heads/master@{#35724}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:27]

Patchset 3 (id:??) landed as
https://crrev.com/5c8609de9d597000fdb92dffe954d7ed994488b2
Cr-Commit-Position: refs/heads/master@{#35724}