Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1904083002:
🐬 Don't build khronos_glcts_test on Android (Closed)
DescriptionDon't build khronos_glcts_test on Android
It doesn't pass, so we shouldn't be compiling it
BUG=605551, 550667, 550665
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4
Cr-Commit-Position: refs/heads/master@{#388969}
Patch Set 1 #Messages
Total messages: 24 (13 generated)
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't spend bot time compiling it. BUG=589318 ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't spend bot time compiling it. BUG=589318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't spend bot time compiling it. BUG=589318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't spend bot time compiling it. BUG=605551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904083002/1
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't spend bot time compiling it. BUG=605551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
agrieve@chromium.org changed reviewers: + dpranke@chromium.org, sievers@chromium.org
dpranke@chromium.org changed reviewers: + kbr@chromium.org
lgtm, but I'd like kbr@ to approve this as well; maybe we should be making it pass instead?
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551, 550667, 550665 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
I updated the CL description to reference a couple more related bugs. Unfortunately lgtm.
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904083002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904083002/1
Message was sent while issue was closed.
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551, 550667, 550665 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551, 550667, 550665 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551, 550667, 550665 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't build khronos_glcts_test on Android It doesn't pass, so we shouldn't be compiling it BUG=605551, 550667, 550665 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4 Cr-Commit-Position: refs/heads/master@{#388969} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4 Cr-Commit-Position: refs/heads/master@{#388969} |
