Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 1904073002: headless: Move hidden commands and events to experimental domains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index f068456109ca8b31d55773094fa20da98056478b..76033f5af3227979782a6da489952e5e3b3b29c8 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -119,11 +119,11 @@ class HeadlessDevToolsClientCallbackTest : public HeadlessDevToolsClientTest {
void RunDevToolsClientTest() override {
// Null callback without parameters.
- devtools_client_->GetRuntime()->Run();
+ devtools_client_->GetRuntime()->GetExperimental()->Run();
// Null callback with parameters.
devtools_client_->GetRuntime()->Evaluate("true");
// Non-null callback without parameters.
- devtools_client_->GetRuntime()->Disable(
+ devtools_client_->GetRuntime()->GetExperimental()->Disable(
base::Bind(&HeadlessDevToolsClientCallbackTest::OnFirstResult,
base::Unretained(this)));
// Non-null callback with parameters.
@@ -182,4 +182,24 @@ class HeadlessDevToolsClientObserverTest : public HeadlessDevToolsClientTest,
DEVTOOLS_CLIENT_TEST_F(HeadlessDevToolsClientObserverTest);
+class HeadlessDevToolsClientExperimentalTest
+ : public HeadlessDevToolsClientTest,
+ page::ExperimentalObserver {
+ public:
+ void RunDevToolsClientTest() override {
+ EXPECT_TRUE(embedded_test_server()->Start());
+ devtools_client_->GetPage()->GetExperimental()->AddObserver(this);
+ devtools_client_->GetPage()->Enable();
+ devtools_client_->GetPage()->Navigate(
+ embedded_test_server()->GetURL("/hello.html").spec());
+ }
+
+ void OnFrameStoppedLoading(
+ const page::FrameStoppedLoadingParams& params) override {
+ FinishAsynchronousTest();
+ }
+};
+
+DEVTOOLS_CLIENT_TEST_F(HeadlessDevToolsClientExperimentalTest);
+
} // namespace headless

Powered by Google App Engine
This is Rietveld 408576698