Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: headless/lib/browser/client_api_generator.py

Issue 1904073002: headless: Move hidden commands and events to experimental domains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/client_api_generator.py
diff --git a/headless/lib/browser/client_api_generator.py b/headless/lib/browser/client_api_generator.py
index 8ef466daf8fdeff2e7127414526080d77138dbf1..6df2f2bc2c39019126c8696aeec98ebb3c49dbd1 100644
--- a/headless/lib/browser/client_api_generator.py
+++ b/headless/lib/browser/client_api_generator.py
@@ -351,6 +351,17 @@ def SynthesizeEventTypes(json_api):
domain['types'].append(event_type)
+def HideHiddenDomains(json_api):
+ """Mark all commands and events in hidden domains as hidden."""
+ for domain in json_api['domains']:
+ if not 'hidden' in domain or not domain['hidden']:
+ continue
+ for command in domain.get('commands', []):
+ command['hidden'] = True
+ for event in domain.get('events', []):
+ event['hidden'] = True
+
+
def Generate(jinja_env, output_dirname, json_api, class_name, file_types):
template_context = {
'api': json_api,
@@ -389,6 +400,7 @@ if __name__ == '__main__':
SynthesizeEventTypes(json_api)
PatchFullQualifiedRefs(json_api)
CreateTypeDefinitions(json_api)
+ HideHiddenDomains(json_api)
Generate(jinja_env, output_dirname, json_api, 'types', ['cc', 'h'])
Generate(jinja_env, output_dirname, json_api, 'type_conversions', ['h'])
GenerateDomains(jinja_env, output_dirname, json_api, 'domain', ['cc', 'h'])
« no previous file with comments | « no previous file | headless/lib/browser/client_api_generator_unittest.py » ('j') | headless/lib/browser/domain_cc.template » ('J')

Powered by Google App Engine
This is Rietveld 408576698