headless: Move hidden commands and events to experimental domains

headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
Committed: https://crrev.com/5cd0556825d3dbe6f47ffe023a876192d5d8514a
Cr-Commit-Position: refs/heads/master@{#389086}

[Sami, 2016-04-21 12:22:36]

Description was changed from

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
==========

to

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
==========

[Sami, 2016-04-21 12:22:37]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org

[Sami, 2016-04-21 13:27:42]

+dgozman

[altimin, 2016-04-21 14:49:10]

lgtm with one nit :)

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
File headless/lib/browser/domain_cc.template (right):

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
headless/lib/browser/domain_cc.template:15: ExperimentalDomain*
Domain::GetExperimental() {
Nit: const?

[Sami, 2016-04-21 14:51:13]

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
File headless/lib/browser/domain_cc.template (right):

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
headless/lib/browser/domain_cc.template:15: ExperimentalDomain*
Domain::GetExperimental() {
On 2016/04/21 14:49:10, altimin wrote:
> Nit: const?

I thought about it but it doesn't quite work since you usually want to be able
to call commands on the returned object.

[dgozman, 2016-04-21 17:30:44]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-04-21 17:30:45]

lgtm

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
File headless/lib/browser/domain_cc.template (right):

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
headless/lib/browser/domain_cc.template:21: observers_.AddObserver(observer);
How do you add an Observer to a list of ExperimentalObservers?

[Sami, 2016-04-21 17:39:01]

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
File headless/lib/browser/domain_cc.template (right):

https://codereview.chromium.org/1904073002/diff/1/headless/lib/browser/domain...
headless/lib/browser/domain_cc.template:21: observers_.AddObserver(observer);
On 2016/04/21 17:30:45, dgozman wrote:
> How do you add an Observer to a list of ExperimentalObservers?

It's a bit non-intuitive, but Observer inherits from ExperimentalObserver but
marks all the experimental events as final, so the user can't actually implement
them. This is exactly backwards compared to the agents themselves, where
ExperimentalAgent inherits from Agent, but I couldn't figure out a nicer way to
hide the experimental events from the user.

[Sami, 2016-04-22 12:38:04]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-04-22 12:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, altimin@chromium.org
Link to the patchset: https://codereview.chromium.org/1904073002/#ps60001
(title: "Also require parameters for hidden commands where the entire domain
isn't hidden")

[commit-bot: I haz the power, 2016-04-22 12:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904073002/60001

[commit-bot: I haz the power, 2016-04-22 13:11:23]

Description was changed from

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
==========

to

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
==========

[commit-bot: I haz the power, 2016-04-22 13:11:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:46:40]

Description was changed from

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353
==========

to

==========
headless: Move hidden commands and events to experimental domains

Some DevTools commands are still in development and may change. Move
them to experimental domains to make their status clear. Note that if an
experimental command is made stable, it will still be available through
the experimental domain and existing users will not be affected.

BUG=595353

Committed: https://crrev.com/5cd0556825d3dbe6f47ffe023a876192d5d8514a
Cr-Commit-Position: refs/heads/master@{#389086}
==========

[commit-bot: I haz the power, 2016-04-22 19:46:41]

Patchset 4 (id:??) landed as
https://crrev.com/5cd0556825d3dbe6f47ffe023a876192d5d8514a
Cr-Commit-Position: refs/heads/master@{#389086}