Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904063002: policy docs: Remove confusing reference to ShowModalDialog. (Closed)

Created:
4 years, 8 months ago by Thiemo Nagel
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

policy docs: Remove confusing reference to ShowModalDialog. BUG=574502 Committed: https://crrev.com/a25858d354fe94e3f308a4fd5b40994bdb6f0b68 Cr-Commit-Position: refs/heads/master@{#389089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/policy/resources/policy_templates.json View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Thiemo Nagel
ptal
4 years, 8 months ago (2016-04-22 09:22:43 UTC) #2
Andrew T Wilson (Slow)
lgtm
4 years, 8 months ago (2016-04-22 11:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904063002/1
4 years, 8 months ago (2016-04-22 12:08:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 13:48:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a25858d354fe94e3f308a4fd5b40994bdb6f0b68
Cr-Commit-Position: refs/heads/master@{#389089}

Powered by Google App Engine
This is Rietveld 408576698