Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1904033003: MIPS64: [regexp] do not assume short external strings have a minimum size. (Closed)

Created:
4 years, 8 months ago by Ilija.Pavlovic1
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [regexp] do not assume short external strings have a minimum size. Fix for execution tests on simulator. Port 3518e492c0939759ae1a2623bbd606646ee172f1 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. BUG= Committed: https://crrev.com/71dd5c4380e191f0a4cd1d5b6b044bdf1c04f0f9 Cr-Commit-Position: refs/heads/master@{#35703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/mips64/code-stubs-mips64.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ilija.Pavlovic1
PTAL. Note: - Lines 1686, 1687 are deleted because of similarity with ARM code.
4 years, 8 months ago (2016-04-21 12:15:59 UTC) #2
akos.palfi.imgtec
lgtm
4 years, 8 months ago (2016-04-21 12:40:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904033003/1
4 years, 8 months ago (2016-04-21 12:44:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:14:39 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71dd5c4380e191f0a4cd1d5b6b044bdf1c04f0f9
Cr-Commit-Position: refs/heads/master@{#35703}

Powered by Google App Engine
This is Rietveld 408576698