Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
190403002:
Do not initialize the volume manager for sign in profiles. (Closed)
|
Created:
6 years, 9 months ago by mtomasz Modified:
6 years, 9 months ago Reviewers:
kinaba CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDo not initialize the volume manager for sign in profiles.
Since the volumes are not used, and moreover some of them are shared between profiles, they volumes should not be mounted, and observers shouldn't be added.
TEST=Tested manually on a enterprise enrolled device.
BUG=349298
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255817
Patch Set 1 #
Messages
Total messages: 22 (0 generated)
@kinaba: PTAL. In the meantime I'm going to verify on M-33, that these two patches work fine. Thanks.
lgtm
On 2014/03/07 08:56:25, kinaba (ooo until Mar 9) wrote: > lgtm I had strange compiling problems with building the R33 branch on my Linux box. I'll try again on Monday before merging.
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/190403002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/190403002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/190403002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/190403002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by mtomasz@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/190403002/1
Message was sent while issue was closed.
Change committed as 255817 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
