Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1904013002: [build] Fix build dependencies for embedded snapshot (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix build dependencies for embedded snapshot The external snapshot target is missing a few build dependencies. TBR=vogelheim@chromium.org, yangguo@chromium.org, clemensh@chromium.org Committed: https://crrev.com/8127557ec2b8a53d9f1a1915a0fe170b0c306b32 Cr-Commit-Position: refs/heads/master@{#35686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904013002/1
4 years, 8 months ago (2016-04-21 07:42:18 UTC) #2
Michael Achenbach
TBR
4 years, 8 months ago (2016-04-21 07:43:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904013002/1
4 years, 8 months ago (2016-04-21 07:44:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 08:03:20 UTC) #10
Yang
On 2016/04/21 08:03:20, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) lgtm.
4 years, 8 months ago (2016-04-21 08:11:40 UTC) #11
vogelheim
lgtm
4 years, 8 months ago (2016-04-21 08:55:18 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8127557ec2b8a53d9f1a1915a0fe170b0c306b32
Cr-Commit-Position: refs/heads/master@{#35686}

Powered by Google App Engine
This is Rietveld 408576698