Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1904003003: X87: [regexp] do not assume short external strings have a minimum size. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [regexp] do not assume short external strings have a minimum size. port 3518e492c0939759ae1a2623bbd606646ee172f1 (r35660) original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. BUG= Committed: https://crrev.com/644bade748fafb1f2e8ab25ca33473a4c77c006d Cr-Commit-Position: refs/heads/master@{#35681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -45 lines) Patch
M src/x87/code-stubs-x87.cc View 6 chunks +30 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-21 03:40:03 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-21 03:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904003003/1
4 years, 8 months ago (2016-04-21 03:45:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 05:02:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/644bade748fafb1f2e8ab25ca33473a4c77c006d
Cr-Commit-Position: refs/heads/master@{#35681}

Powered by Google App Engine
This is Rietveld 408576698