Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1904003002: CrossThreadPersistentRegion will only trace objects belonging to the current GCing ThreadHeap (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrossThreadPersistentRegion will only trace objects belonging to the current GCing ThreadHeap CrossThreadPersistentRegion will be globally shared so we need to limit the tracing to objects belonging to the current GCing ThreadHeap. BUG=591606 Committed: https://crrev.com/8cc8d1cd549bcb95653e501f6f2a4b77170d1d1a Cr-Commit-Position: refs/heads/master@{#389433} Committed: https://crrev.com/371965616636dbdaed9c91fe0369dcba50abe56b Cr-Commit-Position: refs/heads/master@{#392021}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
keishi
PTAL
4 years, 8 months ago (2016-04-25 06:14:33 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-25 06:54:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904003002/20001
4 years, 8 months ago (2016-04-25 07:25:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 08:46:18 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8cc8d1cd549bcb95653e501f6f2a4b77170d1d1a Cr-Commit-Position: refs/heads/master@{#389433}
4 years, 8 months ago (2016-04-25 08:47:29 UTC) #8
keishi
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1922493002/ by keishi@chromium.org. ...
4 years, 8 months ago (2016-04-25 12:10:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904003002/40001
4 years, 7 months ago (2016-05-06 06:27:13 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 07:37:43 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:39:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/371965616636dbdaed9c91fe0369dcba50abe56b
Cr-Commit-Position: refs/heads/master@{#392021}

Powered by Google App Engine
This is Rietveld 408576698