Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1903973002: Fix indexed_db strong mode warnings. (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 3 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 3 chunks +8 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 8 months ago (2016-04-21 01:51:40 UTC) #2
Alan Knight
lgtm
4 years, 8 months ago (2016-04-21 17:02:28 UTC) #3
Jacob
4 years, 8 months ago (2016-04-21 17:03:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25b88eabe5d3a6bfffdfcac700d9407e945dbd48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698