Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1903963003: Revert of Added tests to check that WebGL extensions are available. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added tests to check that WebGL extensions are available. (patchset #6 id:100001 of https://codereview.chromium.org/1887713006/ ) NOTICE: This was not submitted, see comments for more info. Reason for revert: Seems to break several GPU bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/7301 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/8055 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/7301 Original issue's description: > Added tests to check that WebGL extensions are available. > > BUG=603760 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -214 lines) Patch
D content/test/data/gpu/webgl_extension_test.html View 1 chunk +0 lines, -62 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -20 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 4 chunks +1 line, -97 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +1 line, -35 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Revert of Added tests to check that WebGL extensions are available.
4 years, 8 months ago (2016-04-21 06:39:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903963003/1
4 years, 8 months ago (2016-04-21 06:39:29 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/22664) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 06:41:26 UTC) #4
kjellander_chromium
On 2016/04/21 06:41:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-21 07:06:17 UTC) #5
kjellander_chromium
4 years, 8 months ago (2016-04-21 07:26:31 UTC) #6
On 2016/04/21 07:06:17, kjellander (chromium) wrote:
> On 2016/04/21 06:41:26, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
> >   ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
> >   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Actually, this seems to have been addressed in
> https://codereview.chromium.org/1904843002 so I'm going to wait for that
before
> proceeding with manually resolving the merge conflicts here.

Yepp, it solved all but one error. I'll see if I can create a CL for that myself
instead. Closing this CL now.

Powered by Google App Engine
This is Rietveld 408576698