Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1903913002: [perf] Update perfbot sheriff docs to include buildslave monitoring. (Closed)

Created:
4 years, 8 months ago by dtu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perf] Update perfbot sheriff docs to include buildslave monitoring. Sometimes, a machine goes down, but the waterfall stays green. We want the perfbot health sheriffs to watch out for these kinds of failures. Committed: https://crrev.com/e2ff5a62de1d39929674afc5d111637bd19b35eb Cr-Commit-Position: refs/heads/master@{#388614}

Patch Set 1 #

Patch Set 2 : Wrap text. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M tools/perf/docs/perf_bot_sheriffing.md View 1 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dtu
4 years, 8 months ago (2016-04-20 21:07:12 UTC) #2
sullivan
lgtm Thanks!
4 years, 8 months ago (2016-04-20 21:07:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903913002/20001
4 years, 8 months ago (2016-04-20 21:08:05 UTC) #6
aiolos (Not reviewing)
Great catch. lgtm.
4 years, 8 months ago (2016-04-20 23:46:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:09:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2ff5a62de1d39929674afc5d111637bd19b35eb
Cr-Commit-Position: refs/heads/master@{#388614}

Powered by Google App Engine
This is Rietveld 408576698