blimp/engine/app/engine_settings.cc - Issue 1903873003: blimp: Update animation policy for images on the blimp engine.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/app/engine_settings.cc

Issue 1903873003: blimp: Update animation policy for images on the blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "blimp/engine/app/engine_settings.h"	5 #include "blimp/engine/app/engine_settings.h"

6	6

7 namespace blimp {	7 namespace blimp {

8 namespace engine {	8 namespace engine {

9	9

10 EngineSettings::EngineSettings() : record_whole_document(false) {}	10 EngineSettings::EngineSettings()

	11 : record_whole_document(false),

	12 // Disable animation in images by default.

	13 // See third_party/WebKit/Source/platform/graphics/ImageAnimationPolicy.h

	14 // for details.
	Wez 2016/04/21 00:40:28 nit: I don't think you need the ImageAnimationPoli nit: I don't think you need the ImageAnimationPolicy.h mention here; reader can look up the enum themselves to find the relevant comments. Khushal 2016/04/21 01:20:17 Done. Show quoted text On 2016/04/21 00:40:28, Wez wrote: > nit: I don't think you need the ImageAnimationPolicy.h mention here; reader can > look up the enum themselves to find the relevant comments. Done.
	15 animation_policy(

	16 content::ImageAnimationPolicy::IMAGE_ANIMATION_POLICY_NO_ANIMATION) {}

11	17

12 EngineSettings::~EngineSettings() {}	18 EngineSettings::~EngineSettings() {}

13	19

14 EngineSettings::EngineSettings(const EngineSettings& other) = default;	20 EngineSettings::EngineSettings(const EngineSettings& other) = default;

15	21

16 } // namespace engine	22 } // namespace engine

17 } // namespace blimp	23 } // namespace blimp

OLD	NEW

« blimp/engine/app/engine_settings.h ('K') | « blimp/engine/app/engine_settings.h ('k') | blimp/engine/app/settings_manager.cc » ('j') | blimp/engine/app/settings_manager.cc » ('J')