blimp: Update animation policy for images on the blimp engine.

blimp/engine/app/settings_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <blimp/engine/app/settings_manager.h>
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/web_preferences.h"
 
 namespace blimp {
 namespace engine {
 
 SettingsManager::SettingsManager() {}
 
 SettingsManager::~SettingsManager() {}
 
 void SettingsManager::AddObserver(Observer* observer) {
   observer_list_.AddObserver(observer);
 }
 
 void SettingsManager::RemoveObserver(Observer* observer) {
   observer_list_.RemoveObserver(observer);
 }
 
 void SettingsManager::UpdateWebkitPreferences(content::WebPreferences* prefs) {
   DCHECK(prefs);

[Wez, 2016/04/20 23:09:06]

nit: Also not specific to this CL, but no point DCHECK()ing a pointer
immediately before you de-reference it!

[Khushal, 2016/04/21 00:21:25]

The DCHECK helps since it gives a clear stack trace in case someone passes a
nullptr rather than a segmentation fault.

[Wez, 2016/04/21 00:40:28]

The stack trace will be the same, surely? The only difference will be that the
failing pointer is a small integer, rather than actually zero.

[Khushal, 2016/04/21 01:20:17]

Woops, I didn't notice that. :P
Done.

 
   prefs->record_whole_document = settings_.record_whole_document;
+  prefs->animation_policy = settings_.animation_policy;
 }
 
 const EngineSettings& SettingsManager::GetEngineSettings() const {
   return settings_;
 }
 
 void SettingsManager::UpdateEngineSettings(const EngineSettings& settings) {
   EngineSettings old_settings = settings_;
   settings_ = settings;
 
   if (settings_.record_whole_document != old_settings.record_whole_document) {
     // Notify the observers that the web preferences have changed.
     FOR_EACH_OBSERVER(Observer, observer_list_, OnWebPreferencesChanged());
   }
 }
 
 }  // namespace engine
 }  // namespace blimp