third_party/WebKit/Source/core/dom/ScriptLoader.cpp - Issue 1903803002: Do not block painting for in-body CSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 1903803002: Do not block painting for in-body CSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed premature script execution Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

index ce1d0014e8917172c443e75e693f1f38c1171084..20122c7842771e9d7dbf80b372cf767fccacedd7 100644

--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

@@ -249,7 +249,7 @@ bool ScriptLoader::prepareScript(const TextPosition& scriptStartPosition, Legacy

m_willBeParserExecuted = true;

} else if (client->hasSourceAttribute() && m_parserInserted && !client->asyncAttributeValue()) {

m_willBeParserExecuted = true;

- } else if (!client->hasSourceAttribute() && m_parserInserted && !elementDocument.isRenderingReady()) {

+ } else if (!client->hasSourceAttribute() && m_parserInserted && !elementDocument.isScriptExecutionReady()) {

m_willBeParserExecuted = true;

m_readyToBeParserExecuted = true;

} else if (client->hasSourceAttribute() && !client->asyncAttributeValue() && !m_forceAsync) {