extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc - Issue 1903773003: [chrome.displaySource] Add a base class for audio and video encoders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

Issue 1903773003: [chrome.displaySource] Add a base class for audio and video encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.h ('K') | « extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

index cf137dffac2915402165dbea2325c3bc4f80d2fa..ebdb7bce7e7d042f3ec6ec1480080fb33ed4aaee 100644

--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

@@ -4,13 +4,8 @@

#include "extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h"

-#include "media/base/bind_to_current_loop.h"

namespace extensions {

-using InitParameters = WiFiDisplayVideoEncoder::InitParameters;

-using VideoEncoderCallback = WiFiDisplayVideoEncoder::VideoEncoderCallback;

WiFiDisplayVideoEncoder::InitParameters::InitParameters() = default;

WiFiDisplayVideoEncoder::InitParameters::InitParameters(const InitParameters&) =

default;

@@ -19,13 +14,7 @@ WiFiDisplayVideoEncoder::InitParameters::~InitParameters() = default;

WiFiDisplayVideoEncoder::WiFiDisplayVideoEncoder() = default;

WiFiDisplayVideoEncoder::~WiFiDisplayVideoEncoder() = default;

-void WiFiDisplayVideoEncoder::SetCallbacks(

- const EncodedFrameCallback& encoded_callback,

- const base::Closure& error_callback) {

- encoded_callback_ = media::BindToCurrentLoop(encoded_callback);

- error_callback_ = media::BindToCurrentLoop(error_callback);

+// static

void WiFiDisplayVideoEncoder::Create(

const InitParameters& params,

const VideoEncoderCallback& encoder_callback) {