Fix file fuzz test failure

runtime/bin/file.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/file.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 770 matching lines @@
       }
     } else {
       return CObject::FileClosedError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::SetPositionRequest(const CObjectArray& request) {
-  if ((request.Length() == 2) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t position = CObjectInt32OrInt64ToInt64(request[1]);
-      if (file->SetPosition(position)) {
-        return CObject::True();
+    if ((request.Length() == 2) && request[1]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t position = CObjectInt32OrInt64ToInt64(request[1]);
+        if (file->SetPosition(position)) {
+          return CObject::True();
+        } else {
+          return CObject::NewOSError();
+        }
       } else {
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::TruncateRequest(const CObjectArray& request) {
-  if ((request.Length() == 2) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
-      if (file->Truncate(length)) {
-        return CObject::True();
+    if ((request.Length() == 2) && request[1]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
+        if (file->Truncate(length)) {
+          return CObject::True();
+        } else {
+          return CObject::NewOSError();
+        }
       } else {
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::LengthRequest(const CObjectArray& request) {
   if ((request.Length() == 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
@@ skipping 74 matching lines @@
       }
     } else {
       return CObject::FileClosedError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::WriteByteRequest(const CObjectArray& request) {
-  if ((request.Length() == 2) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t byte = CObjectInt32OrInt64ToInt64(request[1]);
-      uint8_t buffer = static_cast<uint8_t>(byte & 0xff);
-      bool success = file->WriteFully(reinterpret_cast<void*>(&buffer), 1);
-      if (success) {
-        return new CObjectInt64(CObject::NewInt64(1));
+    if ((request.Length() == 2) && request[1]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t byte = CObjectInt32OrInt64ToInt64(request[1]);
+        uint8_t buffer = static_cast<uint8_t>(byte & 0xff);
+        bool success = file->WriteFully(reinterpret_cast<void*>(&buffer), 1);
+        if (success) {
+          return new CObjectInt64(CObject::NewInt64(1));
+        } else {
+          return CObject::NewOSError();
+        }
       } else {
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::ReadRequest(const CObjectArray& request) {
-  if ((request.Length() == 2) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
-      Dart_CObject* io_buffer = CObject::NewIOBuffer(length);
-      ASSERT(io_buffer != NULL);
-      uint8_t* data = io_buffer->value.as_external_typed_data.data;
-      int64_t bytes_read = file->Read(data, length);
-      if (bytes_read >= 0) {
-        CObjectExternalUint8Array* external_array =
-            new CObjectExternalUint8Array(io_buffer);
-        external_array->SetLength(bytes_read);
-        CObjectArray* result = new CObjectArray(CObject::NewArray(2));
-        result->SetAt(0, new CObjectIntptr(CObject::NewInt32(0)));
-        result->SetAt(1, external_array);
-        return result;
+    if ((request.Length() == 2) && request[1]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
+        Dart_CObject* io_buffer = CObject::NewIOBuffer(length);
+        ASSERT(io_buffer != NULL);
+        uint8_t* data = io_buffer->value.as_external_typed_data.data;
+        int64_t bytes_read = file->Read(data, length);
+        if (bytes_read >= 0) {
+          CObjectExternalUint8Array* external_array =
+              new CObjectExternalUint8Array(io_buffer);
+          external_array->SetLength(bytes_read);
+          CObjectArray* result = new CObjectArray(CObject::NewArray(2));
+          result->SetAt(0, new CObjectIntptr(CObject::NewInt32(0)));
+          result->SetAt(1, external_array);
+          return result;
+        } else {
+          CObject::FreeIOBufferData(io_buffer);
+          return CObject::NewOSError();
+        }
       } else {
-        CObject::FreeIOBufferData(io_buffer);
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::ReadIntoRequest(const CObjectArray& request) {
-  if ((request.Length() == 2) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
-      Dart_CObject* io_buffer = CObject::NewIOBuffer(length);
-      ASSERT(io_buffer != NULL);
-      uint8_t* data = io_buffer->value.as_external_typed_data.data;
-      int64_t bytes_read = file->Read(data, length);
-      if (bytes_read >= 0) {
-        CObjectExternalUint8Array* external_array =
-            new CObjectExternalUint8Array(io_buffer);
-        external_array->SetLength(bytes_read);
-        CObjectArray* result = new CObjectArray(CObject::NewArray(3));
-        result->SetAt(0, new CObjectIntptr(CObject::NewInt32(0)));
-        result->SetAt(1, new CObjectInt64(CObject::NewInt64(bytes_read)));
-        result->SetAt(2, external_array);
-        return result;
+    if ((request.Length() == 2) && request[1]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t length = CObjectInt32OrInt64ToInt64(request[1]);
+        Dart_CObject* io_buffer = CObject::NewIOBuffer(length);
+        ASSERT(io_buffer != NULL);
+        uint8_t* data = io_buffer->value.as_external_typed_data.data;
+        int64_t bytes_read = file->Read(data, length);
+        if (bytes_read >= 0) {
+          CObjectExternalUint8Array* external_array =
+              new CObjectExternalUint8Array(io_buffer);
+          external_array->SetLength(bytes_read);
+          CObjectArray* result = new CObjectArray(CObject::NewArray(3));
+          result->SetAt(0, new CObjectIntptr(CObject::NewInt32(0)));
+          result->SetAt(1, new CObjectInt64(CObject::NewInt64(bytes_read)));
+          result->SetAt(2, external_array);
+          return result;
+        } else {
+          CObject::FreeIOBufferData(io_buffer);
+          return CObject::NewOSError();
+        }
       } else {
-        CObject::FreeIOBufferData(io_buffer);
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 static int SizeInBytes(Dart_TypedData_Type type) {
   switch (type) {
     case Dart_TypedData_kInt8:
     case Dart_TypedData_kUint8:
@@ skipping 12 matching lines @@
       return 8;
     default:
       break;
   }
   UNREACHABLE();
   return -1;
 }
 
 
 CObject* File::WriteFromRequest(const CObjectArray& request) {
-  if ((request.Length() == 4) &&
-      request[0]->IsIntptr() &&
-      (request[1]->IsTypedData() || request[1]->IsArray()) &&
-      request[2]->IsInt32OrInt64() &&
-      request[3]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t start = CObjectInt32OrInt64ToInt64(request[2]);
-      int64_t end = CObjectInt32OrInt64ToInt64(request[3]);
-      int64_t length = end - start;
-      uint8_t* buffer_start;
-      if (request[1]->IsTypedData()) {
-        CObjectTypedData typed_data(request[1]);
-        start = start * SizeInBytes(typed_data.Type());
-        length = length * SizeInBytes(typed_data.Type());
-        buffer_start = typed_data.Buffer() + start;
+    if ((request.Length() == 4) &&
+        (request[1]->IsTypedData() || request[1]->IsArray()) &&
+        request[2]->IsInt32OrInt64() &&
+        request[3]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t start = CObjectInt32OrInt64ToInt64(request[2]);
+        int64_t end = CObjectInt32OrInt64ToInt64(request[3]);
+        int64_t length = end - start;
+        uint8_t* buffer_start;
+        if (request[1]->IsTypedData()) {
+          CObjectTypedData typed_data(request[1]);
+          start = start * SizeInBytes(typed_data.Type());
+          length = length * SizeInBytes(typed_data.Type());
+          buffer_start = typed_data.Buffer() + start;
+        } else {
+          CObjectArray array(request[1]);
+          buffer_start = Dart_ScopeAllocate(length);
+          for (int i = 0; i < length; i++) {
+            if (array[i + start]->IsInt32OrInt64()) {
+              int64_t value = CObjectInt32OrInt64ToInt64(array[i + start]);
+              buffer_start[i] = static_cast<uint8_t>(value & 0xFF);
+            } else {
+              // Unsupported type.
+              return CObject::IllegalArgumentError();
+            }
+          }
+          start = 0;
+        }
+        bool success =
+            file->WriteFully(reinterpret_cast<void*>(buffer_start), length);
+        if (success) {
+          return new CObjectInt64(CObject::NewInt64(length));
+        } else {
+          return CObject::NewOSError();
+        }
       } else {
-        CObjectArray array(request[1]);
-        buffer_start = Dart_ScopeAllocate(length);
-        for (int i = 0; i < length; i++) {
-          if (array[i + start]->IsInt32OrInt64()) {
-            int64_t value = CObjectInt32OrInt64ToInt64(array[i + start]);
-            buffer_start[i] = static_cast<uint8_t>(value & 0xFF);
-          } else {
-            // Unsupported type.
-            return CObject::IllegalArgumentError();
-          }
-        }
-        start = 0;
-      }
-      bool success =
-          file->WriteFully(reinterpret_cast<void*>(buffer_start), length);
-      if (success) {
-        return new CObjectInt64(CObject::NewInt64(length));
-      } else {
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::CreateLinkRequest(const CObjectArray& request) {
   if ((request.Length() != 2) ||
       !request[0]->IsString() ||
       !request[1]->IsString()) {
@@ skipping 103 matching lines @@
     CObjectArray* wrapper = new CObjectArray(CObject::NewArray(2));
     wrapper->SetAt(0, new CObjectInt32(CObject::NewInt32(CObject::kSuccess)));
     wrapper->SetAt(1, result);
     return wrapper;
   }
   return CObject::IllegalArgumentError();
 }
 
 
 CObject* File::LockRequest(const CObjectArray& request) {
-  if ((request.Length() == 4) &&
-      request[0]->IsIntptr() &&
-      request[1]->IsInt32OrInt64() &&
-      request[2]->IsInt32OrInt64() &&
-      request[3]->IsInt32OrInt64()) {
+  if ((request.Length() >= 1) && request[0]->IsIntptr()) {
     File* file = CObjectToFilePointer(request[0]);
     RefCntReleaseScope<File> rs(file);
-    if (!file->IsClosed()) {
-      int64_t lock = CObjectInt32OrInt64ToInt64(request[1]);
-      int64_t start = CObjectInt32OrInt64ToInt64(request[2]);
-      int64_t end = CObjectInt32OrInt64ToInt64(request[3]);
-      if (file->Lock(static_cast<File::LockType>(lock), start, end)) {
-        return CObject::True();
+    if ((request.Length() == 4) &&
+        request[1]->IsInt32OrInt64() &&
+        request[2]->IsInt32OrInt64() &&
+        request[3]->IsInt32OrInt64()) {
+      if (!file->IsClosed()) {
+        int64_t lock = CObjectInt32OrInt64ToInt64(request[1]);
+        int64_t start = CObjectInt32OrInt64ToInt64(request[2]);
+        int64_t end = CObjectInt32OrInt64ToInt64(request[3]);
+        if (file->Lock(static_cast<File::LockType>(lock), start, end)) {
+          return CObject::True();
+        } else {
+          return CObject::NewOSError();
+        }
       } else {
-        return CObject::NewOSError();
+        return CObject::FileClosedError();
       }
     } else {
-      return CObject::FileClosedError();
+      return CObject::IllegalArgumentError();
     }
   }
   return CObject::IllegalArgumentError();
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)