Make sure to not remove global error twice.

Make sure to not remove global error twice.

BUG=602812
Committed: https://crrev.com/bdfbc8a7d9f7134f49cfedd07ac1e238a6fb8351
Cr-Commit-Position: refs/heads/master@{#389463}

[MAD, 2016-04-20 17:40:07]

mad@chromium.org changed reviewers:
+ macourteau@chromium.org

[MAD, 2016-04-20 17:45:56]

The CQ bit was checked by mad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 17:46:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903733005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903733005/1

[macourteau, 2016-04-20 17:46:39]

lgtm w/ nit

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_global_error_win.cc (right):

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_global_error_win.cc:161: // This is for cases
where the UI doesn't go away quickly enough and user
nit: this function and the one below have a lot of common code, maybe that can
be extracted into a helper function?

[MAD, 2016-04-20 17:48:12]

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_global_error_win.cc (right):

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_global_error_win.cc:161: // This is for cases
where the UI doesn't go away quickly enough and user
On 2016/04/20 17:46:39, macourteau wrote:
> nit: this function and the one below have a lot of common code, maybe that can
> be extracted into a helper function?

I wouldn't call this a lot of common code... Just a few lines. I don't think
it's worth it.

[macourteau, 2016-04-20 18:04:03]

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_global_error_win.cc (right):

https://codereview.chromium.org/1903733005/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_global_error_win.cc:161: // This is for cases
where the UI doesn't go away quickly enough and user
On 2016/04/20 17:48:12, MAD wrote:
> On 2016/04/20 17:46:39, macourteau wrote:
> > nit: this function and the one below have a lot of common code, maybe that
can
> > be extracted into a helper function?
> 
> I wouldn't call this a lot of common code... Just a few lines. I don't think
> it's worth it.

It's still 10 lines that are exactly the same except for the name of the
histogram. I don't have a strong opinion, but I do think it would be better to
extract these. :)

[commit-bot: I haz the power, 2016-04-20 18:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 18:50:36]

Dry run: This issue passed the CQ dry run.

[MAD, 2016-04-20 19:42:00]

mad@chromium.org changed reviewers:
+ mattm@chromium.org

[MAD, 2016-04-20 19:42:00]

OK, you win... How about this? :-)

Also, adding mattm@ for OWNERS review.

Thanks!

BYE
MAD

[mattm, 2016-04-20 19:52:24]

lgtm

[macourteau, 2016-04-20 19:53:33]

lgtm

[MAD, 2016-04-25 12:40:32]

The CQ bit was checked by mad@chromium.org

[commit-bot: I haz the power, 2016-04-25 12:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903733005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903733005/20001

[commit-bot: I haz the power, 2016-04-25 13:33:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-25 13:36:43]

Description was changed from

==========
Make sure to not remove global error twice.

BUG=602812
==========

to

==========
Make sure to not remove global error twice.

BUG=602812

Committed: https://crrev.com/bdfbc8a7d9f7134f49cfedd07ac1e238a6fb8351
Cr-Commit-Position: refs/heads/master@{#389463}
==========

[commit-bot: I haz the power, 2016-04-25 13:36:44]

Patchset 2 (id:??) landed as
https://crrev.com/bdfbc8a7d9f7134f49cfedd07ac1e238a6fb8351
Cr-Commit-Position: refs/heads/master@{#389463}