cc/tiles/gpu_image_decode_controller_unittest.cc - Issue 1903733003: cc: Implement states for Task for stricter control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/gpu_image_decode_controller_unittest.cc

Issue 1903733003: cc: Implement states for Task for stricter control. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@land_merge_tile_task_runner

Patch Set: feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/tiles/gpu_image_decode_controller_unittest.cc

diff --git a/cc/tiles/gpu_image_decode_controller_unittest.cc b/cc/tiles/gpu_image_decode_controller_unittest.cc

index f5949253ab1ccd43b025a74af5b16bd21d94661a..05d6056338f708bb4e1bf368373fd705ffee2c78 100644

--- a/cc/tiles/gpu_image_decode_controller_unittest.cc

+++ b/cc/tiles/gpu_image_decode_controller_unittest.cc

@@ -38,9 +38,13 @@ void ScheduleTask(TileTask* task) {

}

void RunTask(TileTask* task) {

- task->WillRun();

+ // TODO(prashant.n): Once ScheduleOnOriginThread() and

+ // CompleteOnOriginThread() functions are removed, modify this function

+ // accordingly. (crbug.com/599863)

+ task->state().DidSchedule();

+ task->state().DidStart();

task->RunOnWorkerThread();

- task->DidRun();

+ task->state().DidFinish();

}

void CompleteTask(TileTask* task) {

« no previous file with comments | « cc/raster/tile_task_worker_pool_unittest.cc ('k') | cc/tiles/tile_manager.cc » ('j') | no next file with comments »