cc/raster/tile_task.cc - Issue 1903733003: cc: Implement states for Task for stricter control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/raster/tile_task.cc

Issue 1903733003: cc: Implement states for Task for stricter control. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@land_merge_tile_task_runner

Patch Set: feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/raster/tile_task.cc

diff --git a/cc/raster/tile_task.cc b/cc/raster/tile_task.cc

index 7b44a8e418bff2cae0dd323aef3611edbb4d30a6..4010640a03c44ccae104e4a3c18baa3f58d4330b 100644

--- a/cc/raster/tile_task.cc

+++ b/cc/raster/tile_task.cc

@@ -22,7 +22,7 @@ TileTask::TileTask(bool supports_concurrent_execution,

TileTask::~TileTask() {

DCHECK(!did_schedule_);

- DCHECK(!did_run_ || did_complete_);

+ DCHECK(!state().IsFinished() || did_complete_);

}

void TileTask::WillSchedule() {

« no previous file with comments | « cc/raster/task_graph_work_queue.cc ('k') | cc/raster/tile_task_worker_pool_perftest.cc » ('j') | no next file with comments »