Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2342)

Side by Side Diff: cc/raster/single_thread_task_graph_runner.cc

Issue 1903733003: cc: Implement states for Task for stricter control. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@land_merge_tile_task_runner
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/raster/synchronous_task_graph_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/raster/single_thread_task_graph_runner.h" 5 #include "cc/raster/single_thread_task_graph_runner.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 pair) { return !pair.second.empty(); }); 141 pair) { return !pair.second.empty(); });
142 142
143 if (found == ready_to_run_namespaces.cend()) { 143 if (found == ready_to_run_namespaces.cend()) {
144 return false; 144 return false;
145 } 145 }
146 146
147 const uint16_t category = found->first; 147 const uint16_t category = found->first;
148 auto prioritized_task = work_queue_.GetNextTaskToRun(category); 148 auto prioritized_task = work_queue_.GetNextTaskToRun(category);
149 Task* task = prioritized_task.task; 149 Task* task = prioritized_task.task;
150 150
151 // Call WillRun() before releasing |lock_| and running task.
152 task->WillRun();
153
154 { 151 {
155 base::AutoUnlock unlock(lock_); 152 base::AutoUnlock unlock(lock_);
156 task->RunOnWorkerThread(); 153 task->RunOnWorkerThread();
157 } 154 }
158 155
159 // This will mark task as finished running.
160 task->DidRun();
161
162 work_queue_.CompleteTask(prioritized_task); 156 work_queue_.CompleteTask(prioritized_task);
163 157
164 // If namespace has finished running all tasks, wake up origin thread. 158 // If namespace has finished running all tasks, wake up origin thread.
165 if (work_queue_.HasFinishedRunningTasksInNamespace( 159 if (work_queue_.HasFinishedRunningTasksInNamespace(
166 prioritized_task.task_namespace)) 160 prioritized_task.task_namespace))
167 has_namespaces_with_finished_running_tasks_cv_.Signal(); 161 has_namespaces_with_finished_running_tasks_cv_.Signal();
168 162
169 return true; 163 return true;
170 } 164 }
171 165
172 } // namespace cc 166 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/raster/synchronous_task_graph_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698