chrome/browser/extensions/extension_service.cc - Issue 1903713002: Revert of Rate limit programmatic update checks for extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1903713002: Revert of Rate limit programmatic update checks for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc ('k') | chrome/browser/extensions/updater/extension_updater.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index a16b493c81cdf945a48229006093c64e19e60d44..43f3ca0f8975bbc3986023d6010c84c264950168 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -518,8 +518,7 @@

<< " because it is not installed or pending";

// Delete extension_path since we're not creating a CrxInstaller

// that would do it for us.

- if (file_ownership_passed &&

- !GetFileTaskRunner()->PostTask(

+ if (!GetFileTaskRunner()->PostTask(

FROM_HERE,

base::Bind(&extensions::file_util::DeleteFile, file.path, false)))

NOTREACHED();

@@ -692,12 +691,12 @@

}

void ExtensionService::ReloadExtension(const std::string& extension_id) {

- ReloadExtensionImpl(extension_id, true); // be_noisy

+ ReloadExtensionImpl(extension_id, true); // be_noisy

}

void ExtensionService::ReloadExtensionWithQuietFailure(

const std::string& extension_id) {

- ReloadExtensionImpl(extension_id, false); // be_noisy

+ ReloadExtensionImpl(extension_id, false); // be_noisy

}

bool ExtensionService::UninstallExtension(