Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1903713002: Revert of Rate limit programmatic update checks for extensions (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rate limit programmatic update checks for extensions (patchset #7 id:120001 of https://codereview.chromium.org/1887253002/ ) Reason for revert: This CL is suspected by sheriff-o-matic to have caused the perf regression in the number of static initializers. See crbug.com/605017 for more details. Original issue's description: > Rate limit programmatic update checks for extensions > > Previously extensions could call the runtime.requestUpdateCheck method > as often as every 5 seconds. This CL introduces a more restrictive > policy of around one extra check per autoupdate period, and changes the > implementation location of the rate limiting from within the > ExtensionUpdater code itself to the ChromeRuntimeAPIDelegate, and makes > it more flexible by using net::BackoffEntry. > > BUG=599310 TBR=rdevlin.cronin@chromium.org,asargent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599310, 605017 Committed: https://crrev.com/f420bc5e1085bf754adfa8fb15ab755866e03227 Cr-Commit-Position: refs/heads/master@{#388444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -495 lines) Patch
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h View 4 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 6 chunks +14 lines, -92 lines 0 comments Download
D chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc View 1 chunk +0 lines, -317 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 6 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 6 chunks +72 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/event_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.h View 2 chunks +0 lines, -5 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 4 chunks +0 lines, -14 lines 0 comments Download
D extensions/browser/updater/extension_downloader_test_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
msramek
Created Revert of Rate limit programmatic update checks for extensions
4 years, 8 months ago (2016-04-20 08:18:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903713002/1
4 years, 8 months ago (2016-04-20 08:19:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 08:19:46 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f420bc5e1085bf754adfa8fb15ab755866e03227
Cr-Commit-Position: refs/heads/master@{#388444}

Powered by Google App Engine
This is Rietveld 408576698