Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java

Issue 1903673003: [Merge M50] aw: Do not destroy functor in destroy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java b/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
index 597313b7deba46b027a806523f1e701391749c9d..c618b1a1f8918e8e0d04fc9d07d0eb3a000bbe6f 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
@@ -16,8 +16,7 @@ import org.chromium.content.common.CleanupReference;
* Simple Java abstraction and wrapper for the native DrawGLFunctor flow.
* An instance of this class can be constructed, bound to a single view context (i.e. AwContennts)
* and then drawn and detached from the view tree any number of times (using requestDrawGL and
- * detach respectively). Then when finished with, it can be explicitly released by calling
- * destroy() or will clean itself up as required via finalizer / CleanupReference.
+ * detach respectively).
*/
class DrawGLFunctor {
private static final String TAG = DrawGLFunctor.class.getSimpleName();
@@ -36,17 +35,6 @@ class DrawGLFunctor {
mWebViewDelegate = webViewDelegate;
}
- public void destroy() {
- detach();
- if (mCleanupReference != null) {
- mCleanupReference.cleanupNow();
- mCleanupReference = null;
- mDestroyRunnable = null;
- mWebViewDelegate = null;
- mContainerView = null;
- }
- }
-
public void detach() {
if (mWebViewDelegate != null && mContainerView != null) {
mWebViewDelegate.detachDrawGlFunctor(mContainerView, mNativeDrawGLFunctor);
« no previous file with comments | « no previous file | android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698