content/child/child_thread_impl.cc - Issue 1903663004: IPC: Fix attachment brokering race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/child_thread_impl.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (scoped_ptr->std::unique_ptr) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/child_thread_impl.cc

diff --git a/content/child/child_thread_impl.cc b/content/child/child_thread_impl.cc

index d3f45dfc80278bc47ad19b6d3fcb3444f4e41f4d..b7aa75e4f8fb60c830c520f87e932987936424c7 100644

--- a/content/child/child_thread_impl.cc

+++ b/content/child/child_thread_impl.cc

@@ -472,10 +472,10 @@ void ChildThreadImpl::Init(const Options& options) {

channel_->AddFilter(startup_filter);

}

- ConnectChannel(options.use_mojo_channel, options.in_process_ipc_token);

IPC::AttachmentBroker* broker = IPC::AttachmentBroker::GetGlobal();

if (broker && !broker->IsPrivilegedBroker())

broker->RegisterBrokerCommunicationChannel(channel_.get());

+ ConnectChannel(options.use_mojo_channel, options.in_process_ipc_token);

int connection_timeout = kConnectionTimeoutS;

std::string connection_override =