Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: remoting/host/desktop_process.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from tsepez. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_process.cc
diff --git a/remoting/host/desktop_process.cc b/remoting/host/desktop_process.cc
index ca03a105bdb03c7292478c4b9a76b9bace9ab3cf..525e1f66bb73b54783c6d3f78c2147e4ec8be031 100644
--- a/remoting/host/desktop_process.cc
+++ b/remoting/host/desktop_process.cc
@@ -140,14 +140,12 @@ bool DesktopProcess::Start(
}
// Connect to the daemon.
- daemon_channel_ =
- IPC::ChannelProxy::Create(daemon_channel_name_, IPC::Channel::MODE_CLIENT,
- this, io_task_runner.get());
-
+ daemon_channel_.reset(new IPC::ChannelProxy(this, io_task_runner.get()));
IPC::AttachmentBrokerUnprivileged::CreateBrokerIfNeeded();
IPC::AttachmentBroker* broker = IPC::AttachmentBroker::GetGlobal();
if (broker && !broker->IsPrivilegedBroker())
broker->RegisterBrokerCommunicationChannel(daemon_channel_.get());
+ daemon_channel_->Init(daemon_channel_name_, IPC::Channel::MODE_CLIENT, true);
// Pass |desktop_pipe| to the daemon.
daemon_channel_->Send(

Powered by Google App Engine
This is Rietveld 408576698