ipc/ipc_test_base.h - Issue 1903663004: IPC: Fix attachment brokering race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_test_base.h

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_test_base.h

diff --git a/ipc/ipc_test_base.h b/ipc/ipc_test_base.h

index 86178b0c5f0130d6a66be16ca038544cf31d51c7..1168e426d40f403c1d179acc1b3bf150303b2811 100644

--- a/ipc/ipc_test_base.h

+++ b/ipc/ipc_test_base.h

@@ -105,6 +105,10 @@ class IPCTestBase : public base::MultiProcessTest {

IPC::Channel* channel() { return channel_.get(); }

IPC::ChannelProxy* channel_proxy() { return channel_proxy_.get(); }

+ void set_channel_proxy(scoped_ptr<IPC::ChannelProxy> proxy) {

+ DCHECK(!channel_proxy_);

+ channel_proxy_.swap(proxy);

+ }

const base::Process& client_process() const { return client_process_; }

scoped_refptr<base::SequencedTaskRunner> task_runner();