ipc/ipc_channel_win.cc - Issue 1903663004: IPC: Fix attachment brokering race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_win.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_win.cc

diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc

index 62918627c17f5f782ed1f2ac89c4463c95b16078..057b9a50787ea329616fb85a7cb35bcd2abc284e 100644

--- a/ipc/ipc_channel_win.cc

+++ b/ipc/ipc_channel_win.cc

@@ -392,6 +392,8 @@ bool ChannelWin::CreatePipe(const IPC::ChannelHandle &channel_handle,

}

bool ChannelWin::Connect() {

+ WillConnect();

DLOG_IF(WARNING, thread_check_.get()) << "Connect called more than once";

if (!thread_check_.get())