ipc/ipc_channel_posix.cc - Issue 1903663004: IPC: Fix attachment brokering race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: runtime error Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_posix.cc

diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc

index b0a8c38652feef2fe6ed7df90176059f227f53a9..b2e6f08f1e758dd581d13fea57d1b20af2e77f75 100644

--- a/ipc/ipc_channel_posix.cc

+++ b/ipc/ipc_channel_posix.cc

@@ -338,6 +338,8 @@ bool ChannelPosix::CreatePipe(

}

bool ChannelPosix::Connect() {

+ OnConnect();

if (!server_listen_pipe_.is_valid() && !pipe_.is_valid()) {

DLOG(WARNING) << "Channel creation failed: " << pipe_name_;

return false;